Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: status for completed pods in workload view #2729

Merged
merged 1 commit into from
Jun 16, 2024

Conversation

prasadkatti
Copy link
Contributor

@prasadkatti prasadkatti commented Jun 5, 2024

fixes #2720

Here is a debug log for a table row having the issue -

3:37PM INF Row [hello-28627115-mbm5t 0/1 Completed 0 2m43s 10.30.163.2 ip-10-30-175-245.us-west-2.compute.internal <none> <none>]

The READY column is 0/1 and that leads to the row being marked as DEGRADED.

Before:
CleanShot 2024-06-05 at 16 26 39

After:
CleanShot 2024-06-05 at 16 27 20

Copy link
Owner

@derailed derailed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@prasadkatti Good catch Prasad. Thank you!

@derailed derailed merged commit 626bde1 into derailed:master Jun 16, 2024
3 checks passed
rm-hull added a commit to rm-hull/k9s that referenced this pull request Aug 12, 2024
* 'master' of github.com:derailed/k9s: (169 commits)
  fix: align build image Go version with go.mod (derailed#2812)
  Bump github.com/docker/docker (derailed#2816)
  Bump golangci/golangci-lint-action from 6.0.1 to 6.1.0 (derailed#2813)
  Add comment about Escape keybinding (derailed#2817)
  proper handle OwnerReference for manually created job (derailed#2772)
  [derailed#2773] fix freebsd build failure (derailed#2775)
  install copyright file into correct location (derailed#2780)
  fix status for completed pods in workload view (derailed#2729)
  update deps
  [Maint] Bump grype rev
  K9s/release v0.32.5 (derailed#2740)
  --- (derailed#2707)
  fix view sorting being reset (derailed#2736)
  use policy/v1 instead of policy/v1beta1 (derailed#2732)
  Bump alpine from 3.19.1 to 3.20.0 (derailed#2721)
  fix: jump to namespaceless owner reference (derailed#2718)
  feat: Add plugins for argo-rollouts (derailed#2711)
  Bump golangci/golangci-lint-action from 5.1.0 to 6.0.1 (derailed#2702)
  allow jumping to the owner of the resource (derailed#2700)
  fix: job color based on failures (derailed#2686) (derailed#2698)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Degraded status on jobs in workloads
2 participants